Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go’s Native “errors” Package #1005

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Use Go’s Native “errors” Package #1005

merged 2 commits into from
Jun 18, 2024

Conversation

v0lkan
Copy link
Contributor

@v0lkan v0lkan commented Jun 18, 2024

Use Go’s Native “errors” Package

Description

This PR modifies the code and replaced third-party error-handling libraries
with the native “error” package.

We mainly replace errors.Wrap() with its equivalent errors.Join().

This change reduces dependencies, probably improves performance, and also
makes the codebase more secure.

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult
    to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Additional Comments

Include any additional comments or context about the PR here.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and
    especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available
    under the project's license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project's license and that you have the authority to grant
these rights.


Thank you for your contribution to VMware Secrets Manager
🐢⚡️!

Using the native errors package to reduce dependencies
and improve security.

Signed-off-by: Volkan Ozcelik <me@volkan.io>
Signed-off-by: Volkan Ozcelik <me@volkan.io>
@v0lkan v0lkan self-assigned this Jun 18, 2024
@v0lkan v0lkan merged commit d86917b into main Jun 18, 2024
@v0lkan v0lkan deleted the ovolkan/errors branch June 18, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant